Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 16728005: Fix two type errors and dart2dart status. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix two type errors and dart2dart status. Committed: https://code.google.com/p/dart/source/detail?r=23894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/lib/mirrors/reflect_model_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
TBR to make the build green.
7 years, 6 months ago (2013-06-12 07:38:18 UTC) #1
ahe
Committed patchset #1 manually as r23894 (presubmit successful).
7 years, 6 months ago (2013-06-12 07:38:41 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-12 07:43:11 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698