Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 167003004: Use the dart2js type system for isSubtypeOf and isSubclassOf. (Closed)

Created:
6 years, 10 months ago by karlklose
Modified:
6 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use the dart2js type system for isSubtypeOf and isSubclassOf. R=johnniwinther@google.com BUG= http://dartbug.com/16737 Committed: https://code.google.com/p/dart/source/detail?r=32741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart View 3 chunks +17 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
6 years, 10 months ago (2014-02-18 14:04:21 UTC) #1
Johnni Winther
lgtm
6 years, 10 months ago (2014-02-18 14:11:09 UTC) #2
karlklose
6 years, 10 months ago (2014-02-18 14:12:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32741 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698