Provide more error-handling customization.

Provide more error-handling customization.

This makes it easier to wrap underlying channels that don't support
errors at all.

R=tjblasi@google.com

Committed: https://github.com/dart-lang/stream_channel/commit/571eb86fc7c5d95a97703adaff98a23b9d06cf33

[tjblasi, 2016-02-04 23:16:01]

lgtm

https://codereview.chromium.org/1669953002/diff/1/lib/src/guarantee_channel.dart
File lib/src/guarantee_channel.dart (right):

https://codereview.chromium.org/1669953002/diff/1/lib/src/guarantee_channel.d...
lib/src/guarantee_channel.dart:170: if (_disconnected) return done;
mega-nit: Since here & line 174 return the same value & the indentation isn't a
big deal here, my preference would be:

if (!_disconnected) {
  ...
}
return done;

Up to you whether to update.

https://codereview.chromium.org/1669953002/diff/1/test/with_guarantees_test.dart
File test/with_guarantees_test.dart (right):

https://codereview.chromium.org/1669953002/diff/1/test/with_guarantees_test.d...
test/with_guarantees_test.dart:128: sinkController.stream.listen(null, onError:
expectAsync((_) {}, count: 0));
line length (might just be Chromium Code Reviews UI)

[nweiz, 2016-02-05 00:10:19]

Description was changed from

==========
Provide more error-handling customization.

This makes it easier to wrap underlying channels that don't support
errors at all.

R=tjblasi@google.com
==========

to

==========
Provide more error-handling customization.

This makes it easier to wrap underlying channels that don't support
errors at all.

R=tjblasi@google.com

Committed:
https://github.com/dart-lang/stream_channel/commit/571eb86fc7c5d95a97703adaff...
==========

[nweiz, 2016-02-05 00:10:20]

Committed patchset #1 (id:1) manually as
571eb86fc7c5d95a97703adaff98a23b9d06cf33 (presubmit successful).