Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 166743002: Make building from bleeding edge tarball possible without Subversion installed (Closed)

Created:
6 years, 10 months ago by Søren Gjesse
Modified:
6 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make building from bleeding edge tarball possible without Subversion installed Look for the svn revision in tools/SVN_REVISION before event trying to run svn. The SVN_REVISIOn file is only created when building a tarball from a bleeding edge revision. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/utils.py View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
6 years, 10 months ago (2014-02-14 13:18:30 UTC) #1
kustermann
LGTM
6 years, 10 months ago (2014-02-14 14:19:10 UTC) #2
Søren Gjesse
6 years, 10 months ago (2014-02-17 08:09:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32713 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698