Improvements to 53-bit overflow checking.

Improvements to 53-bit overflow checking.

- Integer literals that require more than 53 bits will cause a compile-time error.
- Checking is added to unary negate for the case that the most negative
  53-bit integer is negated.
- The tests are improved to also check optimized code.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23774

[srdjan, 2013-06-07 21:03:42]

LGTM

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:10505: // Returns true if the signed Integer i requires
more than 53 bits.
There is no 'i' that is mentioned in the comment.

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:10524: return true;
return !Utils::IsInt(53, value);

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.h#newcod...
runtime/vm/object.h:4015: bool CheckFiftyThreeBitOverflow() const;
Add comment: returns true if overflow.

[zra, 2013-06-07 21:28:27]

Thanks!

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:10505: // Returns true if the signed Integer i requires
more than 53 bits.
On 2013/06/07 21:03:42, srdjan wrote:
> There is no 'i' that is mentioned in the comment.

Removed from comment.

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:10524: return true;
On 2013/06/07 21:03:42, srdjan wrote:
> return !Utils::IsInt(53, value);

Done.

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/16664003/diff/6002/runtime/vm/object.h#newcod...
runtime/vm/object.h:4015: bool CheckFiftyThreeBitOverflow() const;
On 2013/06/07 21:03:42, srdjan wrote:
> Add comment: returns true if overflow.

Done.

[zra, 2013-06-07 21:28:55]

Committed patchset #3 manually as r23774 (presubmit successful).