Issue 1664903003: Properly include the hosted URL in all IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1664903003: Properly include the hosted URL in all IDs. (Closed)

Created:
4 years, 10 months ago by nweiz

Modified:
4 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Properly include the hosted URL in all IDs. The hosted source was dropping these on the floor, causing non-default hosted packages to fail to download. Closes #1386 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/c00b6139361ab2861ba518df9348adf9f62f41dc

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -8 lines)			Patch
M	lib/src/source/hosted.dart	View	4 chunks	+9 lines, -3 lines	0 comments	Download
M	test/descriptor.dart	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	test/get/hosted/get_test.dart	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	test/package_server.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 10 months ago (2016-02-03 20:31:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c00b6139361ab2861ba518df9348adf9f62f41dc (presubmit successful).