Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 16645002: Preliminary support for reflecting on generic types. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
Alan Knight, kasperl
CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, karlklose
Visibility:
Public.

Description

Preliminary support for reflecting on generic types. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23809

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove changes to pkg/serialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart View 1 chunk +3 lines, -1 line 0 comments Download
A + dart/tests/lib/mirrors/generic_list_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
More work is needed in this area, however, this makes pkg/serialization/test/no_library_test.dart get further. @Alan: could ...
7 years, 6 months ago (2013-06-07 14:50:13 UTC) #1
ahe
FYI: I have serialization working now. This CL is part of the changes that needed ...
7 years, 6 months ago (2013-06-10 07:02:14 UTC) #2
ahe
7 years, 6 months ago (2013-06-10 07:02:40 UTC) #3
kasperl
LGTM.
7 years, 6 months ago (2013-06-10 13:05:43 UTC) #4
ahe
Thank you, Kasper! https://codereview.chromium.org/16645002/diff/1/dart/pkg/serialization/lib/src/mirrors_helpers.dart File dart/pkg/serialization/lib/src/mirrors_helpers.dart (right): https://codereview.chromium.org/16645002/diff/1/dart/pkg/serialization/lib/src/mirrors_helpers.dart#newcode19 dart/pkg/serialization/lib/src/mirrors_helpers.dart:19: _getSuperclass(ClassMirror mirror) { I've decided to ...
7 years, 6 months ago (2013-06-10 13:17:25 UTC) #5
ahe
7 years, 6 months ago (2013-06-10 13:24:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r23809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698