Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1664433002: Support shelf 0.7.0. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support shelf 0.7.0. This also updates test to use the new version of shelf_web_socket. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/9c1ec48e414f4ae13a2ae8ec9d3ec57425e9a85c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -645 lines) Patch
M lib/src/runner/browser/browser_manager.dart View 3 chunks +4 lines, -7 lines 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M lib/src/runner/browser/iframe_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M lib/src/runner/browser/static/host.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/runner/browser/suite.dart View 2 chunks +13 lines, -12 lines 0 comments Download
D lib/src/util/multi_channel.dart View 1 chunk +0 lines, -243 lines 0 comments Download
D lib/src/util/stream_channel.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pubspec.yaml View 1 chunk +3 lines, -2 lines 0 comments Download
M test/runner/browser/chrome_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/code_server.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/runner/browser/content_shell_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/dartium_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/firefox_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/internet_explorer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/phantom_js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/safari_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D test/util/multi_channel_test.dart View 1 chunk +0 lines, -310 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-02 20:55:15 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1664433002/diff/1/test/runner/browser/code_server.dart File test/runner/browser/code_server.dart (right): https://codereview.chromium.org/1664433002/diff/1/test/runner/browser/code_server.dart#newcode6 test/runner/browser/code_server.dart:6: import 'dart:io'; unused import? https://codereview.chromium.org/1664433002/diff/1/test/runner/browser/code_server.dart#newcode82 test/runner/browser/code_server.dart:82: Future<WebSocketChannel> handleWebSocket() ...
4 years, 10 months ago (2016-02-02 21:16:14 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-02-02 21:36:41 UTC) #3
nweiz
Committed patchset #2 (id:20001) manually as 9c1ec48e414f4ae13a2ae8ec9d3ec57425e9a85c (presubmit successful).
4 years, 10 months ago (2016-02-02 21:37:14 UTC) #5
nweiz
4 years, 10 months ago (2016-02-02 21:37:26 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1664433002/diff/1/test/runner/browser/code_se...
File test/runner/browser/code_server.dart (right):

https://codereview.chromium.org/1664433002/diff/1/test/runner/browser/code_se...
test/runner/browser/code_server.dart:6: import 'dart:io';
On 2016/02/02 21:16:14, kevmoo wrote:
> unused import?

Done.

https://codereview.chromium.org/1664433002/diff/1/test/runner/browser/code_se...
test/runner/browser/code_server.dart:82: Future<WebSocketChannel>
handleWebSocket() {
On 2016/02/02 21:16:14, kevmoo wrote:
> Missing import 'package:http_parser/http_parser.dart';

Done.

Powered by Google App Engine
This is Rietveld 408576698