Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 166433002: Revert "Fix language tests wrt. warnings." (Closed)

Created:
6 years, 10 months ago by Johnni Winther
Modified:
6 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Fix language tests wrt. warnings." This reverts commit r32689. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32690

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -243 lines) Patch
M tests/language/abstract_exact_selector_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/abstract_factory_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/abstract_getter_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M tests/language/abstract_runtime_error_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/language/assign_top_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/bad_named_parameters2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/bad_named_parameters_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
tests/language/bit_operations_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/call_constructor_on_unresolvable_class_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/call_nonexistent_constructor_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
tests/language/checked_null_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
tests/language/checked_setter2_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/checked_setter3_test.dart View 1 chunk +8 lines, -10 lines 0 comments Download
M tests/language/checked_setter_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
tests/language/class_literal_test.dart View 2 chunks +28 lines, -28 lines 0 comments Download
M tests/language/closure_type_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M tests/language/compile_time_constant_k_test.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M tests/language/compile_time_constant_o_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/language/const_objects_are_immutable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/constructor_named_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/constructor_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
tests/language/core_type_check_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/language/crash_6725_part.dart View 1 chunk +0 lines, -73 lines 0 comments Download
M tests/language/crash_6725_test.dart View 1 chunk +61 lines, -3 lines 0 comments Download
tests/language/default_factory_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/default_factory_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/double_to_string_as_exponential2_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/language/double_to_string_as_fixed2_test.dart View 1 chunk +6 lines, -7 lines 0 comments Download
tests/language/double_to_string_as_precision2_test.dart View 1 chunk +6 lines, -7 lines 0 comments Download
tests/language/dynamic_field_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/language/dynamic_prefix_core_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
tests/language/language_analyzer.status View 4 chunks +30 lines, -9 lines 0 comments Download
tests/language/language_analyzer2.status View 4 chunks +30 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
TBR
6 years, 10 months ago (2014-02-14 10:05:39 UTC) #1
karlklose
LGTM.
6 years, 10 months ago (2014-02-14 10:08:30 UTC) #2
Johnni Winther
6 years, 10 months ago (2014-02-14 10:11:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698