Issue 16638013: Adding annotations for native types of type Object or dynamic.

Issue 16638013: Adding annotations for native types of type Object or dynamic. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding annotations for native types of type Object or dynamic. Also added generation warnings to try to detect these. BUG=10946 R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23875

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -32 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	9 chunks	+8 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View		7 chunks	+14 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View		6 chunks	+16 lines, -0 lines	0 comments	Download
M	tests/html/documentfragment_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/html/event_customevent_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View		5 chunks	+125 lines, -10 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/scripts/logging.conf	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		7 chunks	+18 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_AudioContext.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm except for JS('Function',...) https://codereview.chromium.org/16638013/diff/2001/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart File sdk/lib/web_audio/dart2js/web_audio_dart2js.dart (right): https://codereview.chromium.org/16638013/diff/2001/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart#newcode343 sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:343: var function = JS('Function', '#.createScriptProcessor ...

7 years, 6 months ago (2013-06-11 18:54:15 UTC) #2

blois

https://codereview.chromium.org/16638013/diff/2001/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart File sdk/lib/web_audio/dart2js/web_audio_dart2js.dart (right): https://codereview.chromium.org/16638013/diff/2001/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart#newcode343 sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:343: var function = JS('Function', '#.createScriptProcessor || ' On 2013/06/11 ...

7 years, 6 months ago (2013-06-11 19:07:46 UTC) #3

blois

7 years, 6 months ago (2013-06-11 19:47:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23875 (presubmit successful).

Expand Messages | Collapse Messages