Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 16638012: Switch code generation on ARM from softfp ABI to hardfp ABI. (Closed)

Created:
7 years, 6 months ago by regis
Modified:
7 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Switch code generation on ARM from softfp ABI to hardfp ABI. Support leaf float runtime calls in ARM simulator. Enable previously failing tests. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23868

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -53 lines) Patch
M runtime/vm/code_generator.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/constants_arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/runtime_entry.h View 4 chunks +9 lines, -7 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M runtime/vm/runtime_entry_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 9 chunks +38 lines, -8 lines 0 comments Download
M runtime/vm/store_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 6 months ago (2013-06-11 16:17:33 UTC) #1
zra
lgtm
7 years, 6 months ago (2013-06-11 16:34:02 UTC) #2
regis
7 years, 6 months ago (2013-06-11 16:47:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23868 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698