Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 16638009: Use gnueabihf for ARM + enabled corelib/isolate/lib/standalone tests on ARM again (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
zra, regis, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use gnueabihf for ARM + enabled corelib/isolate/lib/standalone tests on ARM again R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=23854

Patch Set 1 #

Patch Set 2 : #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M tests/corelib/corelib.status View 1 chunk +0 lines, -3 lines 2 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -3 lines 1 comment Download
M tests/lib/lib.status View 1 chunk +0 lines, -3 lines 1 comment Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -3 lines 1 comment Download
M tools/build.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/gyp/configurations_make.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 6 months ago (2013-06-11 12:43:37 UTC) #1
regis
LGTM https://codereview.chromium.org/16638009/diff/2001/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/16638009/diff/2001/tests/corelib/corelib.status#newcode108 tests/corelib/corelib.status:108: *: Skip If these tests pass on ARM ...
7 years, 6 months ago (2013-06-11 13:09:14 UTC) #2
kustermann
https://codereview.chromium.org/16638009/diff/2001/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/16638009/diff/2001/tests/corelib/corelib.status#newcode108 tests/corelib/corelib.status:108: *: Skip On 2013/06/11 13:09:14, regis wrote: > If ...
7 years, 6 months ago (2013-06-11 14:21:37 UTC) #3
kustermann
7 years, 6 months ago (2013-06-11 14:21:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698