Issue 16636003: Blink IDL roll.

Issue 16636003: Blink IDL roll. (Closed)

Created:
7 years, 6 months ago by Anton Muhin

Modified:
7 years, 6 months ago

Reviewers:
vsm, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Blink IDL roll. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=23752

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1695 lines, -121 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	36 chunks	+561 lines, -53 lines	2 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	34 chunks	+712 lines, -66 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	26 chunks	+382 lines, -1 line	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://chromiumcodereview.appspot.com/16636003/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://chromiumcodereview.appspot.com/16636003/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode23065 sdk/lib/html/dart2js/html_dart2js.dart:23065: if ((index_OR_name is String || index_OR_name == null)) ...

7 years, 6 months ago (2013-06-07 15:44:31 UTC) #2

Anton Muhin

Thanks, Vijay, when I am going to submit it with a hope someone will take ...

7 years, 6 months ago (2013-06-07 16:23:23 UTC) #3

vsm

On 2013/06/07 16:23:23, Anton Muhin wrote: > Thanks, Vijay, when I am going to submit ...

7 years, 6 months ago (2013-06-07 16:28:45 UTC) #4

Anton Muhin

7 years, 6 months ago (2013-06-07 16:34:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r23752 (presubmit successful).

Expand Messages | Collapse Messages