Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 166333003: Add support for a "fine" barback log level. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, Jennifer Messerly
Visibility:
Public.

Description

Add support for a "fine" barback log level. This level is not printed by default, but will be printed by pub if --verbose is set. Also update the observe/polymer version constraints. This change is backwards-compatible from a transformer implementer's perspective, so the lower bound doesn't need to be incremented. BUG=16945 R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=33000

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M pkg/barback/lib/src/log.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/barback/lib/src/package_graph.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/lib/src/transform_logger.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 1 comment Download
M pkg/barback/test/logger_test.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/barback/test/transformer/log.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/observe/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback.dart View 1 chunk +1 line, -1 line 2 comments Download
M sdk/lib/_internal/pub/lib/src/barback/build_environment.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 10 months ago (2014-02-24 21:57:17 UTC) #1
Bob Nystrom
LGTM, though I hope revving barback doesn't cause too much friction in the ecosystem. https://codereview.chromium.org/166333003/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart ...
6 years, 10 months ago (2014-02-24 22:19:55 UTC) #2
nweiz
Old pubs won't work with new barbacks, but the new pub will work with old ...
6 years, 10 months ago (2014-02-25 00:57:58 UTC) #3
nweiz
Committed patchset #1 manually as r33000 (presubmit successful).
6 years, 10 months ago (2014-02-25 01:24:33 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/166333003/diff/1/pkg/barback/pubspec.yaml File pkg/barback/pubspec.yaml (right): https://codereview.chromium.org/166333003/diff/1/pkg/barback/pubspec.yaml#newcode11 pkg/barback/pubspec.yaml:11: version: 0.12.0-dev mmm, not sure I follow why this ...
6 years, 10 months ago (2014-02-25 17:56:07 UTC) #5
Siggi Cherem (dart-lang)
6 years, 10 months ago (2014-02-25 17:59:06 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/166333003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback.dart (right):

https://codereview.chromium.org/166333003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback.dart:34: final supportedVersion = new
Version(0, 12, 0);
On 2014/02/25 17:56:07, Siggi Cherem (dart-lang) wrote:
> If it can't be 0.11.2, could we support a wider version range here? (for
example
> ">=0.11.0 <0.13.0 in this case?)
> 
> The reason I ask is because we'd like to not release polymer/observe at this
> time. We are trying to bundle together a bunch of breaking changes together to
> minimize user's disruption.
> 
> With the change as it is, we'll have to download the latest version of our
> packages, modify them on the side to fix the constraint, and republish them.
But
> then there would be nothing in the repo history about this hot-fix. I prefer
to
> avoid it is possible (maybe I'd be less concerned doing that if we could have
> our own branches in a separate repo where we could keep track of each
version). 

Looking more closely I realize that that you depend on LogLevel.FINE in the code
so you wont be able to request 0.11.

Another idea - if it's possible to make barback's version 0.11.2, could this
'supportedVersion' start at 0.11.2 instead of 0.11.0?

Powered by Google App Engine
This is Rietveld 408576698