Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1662783004: Properly use the sandbox in tag_test.dart. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly use the sandbox in tag_test.dart. scheduled_test doesn't play nicely with multiple setUp calls. Closes #392 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/a2b96173c2e1633621619f4fbd9087de8fe7be3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M test/runner/tag_test.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 10 months ago (2016-02-04 01:27:05 UTC) #1
kevmoo
4 years, 10 months ago (2016-02-04 17:17:15 UTC) #2
kevmoo
lgtm
4 years, 10 months ago (2016-02-04 17:17:19 UTC) #3
nweiz
4 years, 10 months ago (2016-02-04 19:50:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2b96173c2e1633621619f4fbd9087de8fe7be3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698