Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 166093006: pkg/docgen: removed py files, doc/README.txt, fixed analyzer warning (Closed)

Created:
6 years, 10 months ago by kevmoo
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: removed py files, doc/README.txt, fixed analyzer warning R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32758

Patch Set 1 #

Total comments: 1

Patch Set 2 : a bit more strict #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -288 lines) Patch
D pkg/docgen/bin/dartdoc.py View 1 chunk +0 lines, -164 lines 0 comments Download
D pkg/docgen/bin/upload_docgen.py View 1 chunk +0 lines, -116 lines 0 comments Download
D pkg/docgen/doc/README.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 5 chunks +6 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
kevmoo
6 years, 10 months ago (2014-02-14 22:20:28 UTC) #1
Emily Fortuna
mostly lgtm https://codereview.chromium.org/166093006/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/166093006/diff/1/pkg/docgen/lib/docgen.dart#newcode1593 pkg/docgen/lib/docgen.dart:1593: //TODO(efortuna): an valid cases where parts.length is ...
6 years, 10 months ago (2014-02-14 22:26:40 UTC) #2
kevmoo
PTAL https://codereview.chromium.org/166093006/diff/60001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/166093006/diff/60001/pkg/docgen/lib/docgen.dart#newcode1593 pkg/docgen/lib/docgen.dart:1593: throw new StateError('More than two items is not ...
6 years, 10 months ago (2014-02-17 20:27:20 UTC) #3
Emily Fortuna
lgtm
6 years, 10 months ago (2014-02-18 19:21:47 UTC) #4
kevmoo
6 years, 10 months ago (2014-02-18 19:38:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r32758 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698