Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1660513002: pkg/shelf: use async and enable compression in example (Closed)

Created:
4 years, 10 months ago by kevmoo
Modified:
4 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/shelf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M example/example_server.dart View 1 1 chunk +7 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/message_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
Also fixed an unused import
4 years, 10 months ago (2016-02-02 17:20:31 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1660513002/diff/1/example/example_server.dart File example/example_server.dart (left): https://codereview.chromium.org/1660513002/diff/1/example/example_server.dart#oldcode18 example/example_server.dart:18: shelf.Response _echoRequest(shelf.Request request) { I think it's better ...
4 years, 10 months ago (2016-02-02 19:15:42 UTC) #3
kevmoo
https://codereview.chromium.org/1660513002/diff/1/example/example_server.dart File example/example_server.dart (left): https://codereview.chromium.org/1660513002/diff/1/example/example_server.dart#oldcode18 example/example_server.dart:18: shelf.Response _echoRequest(shelf.Request request) { On 2016/02/02 19:15:42, nweiz wrote: ...
4 years, 10 months ago (2016-02-02 19:21:24 UTC) #4
kevmoo
4 years, 10 months ago (2016-02-02 19:21:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e815aac36c69f2c06a594bee9b68d29f50a5a330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698