Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1659313002: Fix the tests. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/json_rpc_2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the tests. It seems we tickled a core library inconsistency (dart-lang/sdk#25655): although on the VM `FormatException.source` is set for JSON parse errors, it is not set using dart2js. R=rnystrom@google.com Committed: https://github.com/dart-lang/json_rpc_2/commit/eed4a33a32e7d07e2e3aa1c390c79a145f9a1259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/peer_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/server/server_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 10 months ago (2016-02-02 23:17:36 UTC) #1
Bob Nystrom
lgtm
4 years, 10 months ago (2016-02-02 23:24:41 UTC) #2
nweiz
4 years, 10 months ago (2016-02-02 23:37:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eed4a33a32e7d07e2e3aa1c390c79a145f9a1259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698