Issue 1659313002: Fix the tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1659313002: Fix the tests. (Closed)

Created:
4 years, 10 months ago by nweiz

Modified:
4 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/json_rpc_2.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the tests. It seems we tickled a core library inconsistency (dart-lang/sdk#25655): although on the VM `FormatException.source` is set for JSON parse errors, it is not set using dart2js. R=rnystrom@google.com Committed: https://github.com/dart-lang/json_rpc_2/commit/eed4a33a32e7d07e2e3aa1c390c79a145f9a1259

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -3 lines)			Patch
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/peer_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/server/server_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 10 months ago (2016-02-02 23:37:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eed4a33a32e7d07e2e3aa1c390c79a145f9a1259 (presubmit successful).