Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 16592002: Move interop js code out of dart.js (Closed)

Created:
7 years, 6 months ago by vsm
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move interop js code out of dart.js BUG=7973 Note: this is a breaking change and would be advertised as such. Anyone using js-interop would need to explicitly include: <script type="text/javascript" "pkg/browser/lib/interop.js"></script> along with dart.js in their HTML. Those who don't need js-interop can save on this code. Alexandre: I'm imagining interop.js would be the landing spot for dart:js bootstrap code as well. R=alexandre.ardhuin@gmail.com, dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=23855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -249 lines) Patch
M pkg/browser/lib/dart.js View 2 chunks +1 line, -215 lines 0 comments Download
A + pkg/browser/lib/interop.js View 1 chunk +2 lines, -34 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
7 years, 6 months ago (2013-06-06 19:59:38 UTC) #1
alexandre.ardhuin
lgtm
7 years, 6 months ago (2013-06-06 20:07:35 UTC) #2
dgrove
lgtm
7 years, 6 months ago (2013-06-06 23:16:33 UTC) #3
vsm
7 years, 6 months ago (2013-06-11 15:33:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r23855 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698