Issue 1658833002: Be more explicit about JSON error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1658833002: Be more explicit about JSON error handling. (Closed)

Created:
4 years, 10 months ago by nweiz

Modified:
4 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/stream_channel.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Be more explicit about JSON error handling. R=rnystrom@google.com Committed: https://github.com/dart-lang/stream_channel/commit/67c0ae4250571fee50ede63f8f2501e98dff2fae

Patch Set 2 : Code review changes #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
M	CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/json_document_transformer.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/json_document_transformer_test.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1658833002/diff/1/lib/src/json_document_transformer.dart File lib/src/json_document_transformer.dart (right): https://codereview.chromium.org/1658833002/diff/1/lib/src/json_document_transformer.dart#newcode22 lib/src/json_document_transformer.dart:22: /// [FormatException]. If an unencodable object is added ...

4 years, 10 months ago (2016-02-01 22:48:28 UTC) #2

nweiz

4 years, 10 months ago (2016-02-01 23:55:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
67c0ae4250571fee50ede63f8f2501e98dff2fae (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1658833002: Be more explicit about JSON error handling. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages