Code coverage server babysteps.

Code coverage server babysteps.

Largely just structure and (happy part of) the life cycle.
It even works in trivial application, although it does nothing interesting within the touch() function.

R=pquitslund@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=23876

[pquitslund, 2013-06-11 17:18:56]

LGTM.  Superficial tweaks to bring it in line with my understanding of the
emerging style guidelines.  When this gets more substantial, you might add
another more seasoned Dartisan as a reviewer as well.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/bin...
File pkg/analyzer_experimental/bin/coverage_server.dart (right):

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/bin...
pkg/analyzer_experimental/bin/coverage_server.dart:1: library
runtime.coverage.server;
Copyright header?

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/runtime/coverage_lib.dart
(right):

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_lib.dart:1: /// This
library is injected into the applications under coverage.
Copyright?

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
File
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart
(right):

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:1:
/// A library for code coverage support for Dart.
Again.  Probably want a header.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:27:
// prepare path
prepare -> Prepare (upper case)

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:28:
String path = _basePath + '/' + request.uri.path;
var path

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:31:
// may be we have path content
Upper case 'may'

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:41:
// get content from file
More upper case (and below).  Pretty sure the style guide recommends this for
comments.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:43:
File file = new File(path);
var file

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:95:
CompilationUnit unit = _parseCode(code);
Again, drop the type annotation (var unit).

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:114:
Source source = null;
And here.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:129:
int offset = node.end;
And here.

[scheglov, 2013-06-11 19:50:44]

Committed patchset #1 manually as r23876 (presubmit successful).

[scheglov, 2013-06-11 19:54:23]

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/bin...
File pkg/analyzer_experimental/bin/coverage_server.dart (right):

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/bin...
pkg/analyzer_experimental/bin/coverage_server.dart:1: library
runtime.coverage.server;
On 2013/06/11 17:18:56, pquitslund wrote:
> Copyright header?

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/runtime/coverage_lib.dart
(right):

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_lib.dart:1: /// This
library is injected into the applications under coverage.
On 2013/06/11 17:18:56, pquitslund wrote:
> Copyright?

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
File
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart
(right):

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:1:
/// A library for code coverage support for Dart.
On 2013/06/11 17:18:56, pquitslund wrote:
> Again.  Probably want a header.

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:27:
// prepare path
On 2013/06/11 17:18:56, pquitslund wrote:
> prepare -> Prepare (upper case)

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:28:
String path = _basePath + '/' + request.uri.path;
On 2013/06/11 17:18:56, pquitslund wrote:
> var path

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:31:
// may be we have path content
On 2013/06/11 17:18:56, pquitslund wrote:
> Upper case 'may'

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:41:
// get content from file
On 2013/06/11 17:18:56, pquitslund wrote:
> More upper case (and below).  Pretty sure the style guide recommends this for
> comments.

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:43:
File file = new File(path);
On 2013/06/11 17:18:56, pquitslund wrote:
> var file

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:95:
CompilationUnit unit = _parseCode(code);
On 2013/06/11 17:18:56, pquitslund wrote:
> Again, drop the type annotation (var unit).

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:114:
Source source = null;
On 2013/06/11 17:18:56, pquitslund wrote:
> And here.

Done.

https://codereview.chromium.org/16580018/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/runtime/coverage_server_impl.dart:129:
int offset = node.end;
On 2013/06/11 17:18:56, pquitslund wrote:
> And here.

Done.