Issue 16580014: Don't create part.js when there is no deferred loading.

Issue 16580014: Don't create part.js when there is no deferred loading. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't create part.js when there is no deferred loading. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23798

Patch Set 2 : Address review comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -77 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	9 chunks	+47 lines, -50 lines	0 comments	Download
A +	dart/tests/compiler/dart2js/unneeded_part_js_test.dart	View		2 chunks	+27 lines, -27 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/deferred/deferred_function_test.dart	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

While fixing the issue of emitting unneeded part.js, I discovered a few bugs in deferred ...

7 years, 6 months ago (2013-06-07 10:17:18 UTC) #1

kasperl

LGTM! https://codereview.chromium.org/16580014/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/16580014/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3272 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3272: buffer.add('$finishClassesName($classesCollector,$_${namer.CURRENT_ISOLATE},' Long line. https://codereview.chromium.org/16580014/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3276 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3276: buffer I prefer ...

7 years, 6 months ago (2013-06-10 07:27:47 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/16580014/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/16580014/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3272 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3272: buffer.add('$finishClassesName($classesCollector,$_${namer.CURRENT_ISOLATE},' On 2013/06/10 07:27:47, kasperl wrote: ...

7 years, 6 months ago (2013-06-10 07:32:36 UTC) #3

ahe

7 years, 6 months ago (2013-06-10 07:33:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23798 (presubmit successful).

Expand Messages | Collapse Messages