Issue 165723005: Add toIso8601String to DateTime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165723005: Add toIso8601String to DateTime. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add toIso8601String to DateTime. BUG= http://dartbug.com/16902 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32786

Patch Set 2 : Address comments. Add test. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+877 lines, -833 lines)			Patch
	M	sdk/lib/core/date_time.dart	View	1	3 chunks	+48 lines, -28 lines	0 comments	Download
	M	tests/corelib/date_time_test.dart	View	1	1 chunk	+829 lines, -805 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM with tests. https://codereview.chromium.org/165723005/diff/1/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/165723005/diff/1/sdk/lib/core/date_time.dart#newcode447 sdk/lib/core/date_time.dart:447: * The format is always "YYYY-MM-DDTHH:mm:ss.sssZ", ...

6 years, 10 months ago (2014-02-18 10:24:23 UTC) #2

kevmoo

On 2014/02/18 10:24:23, floitsch wrote: > LGTM with tests. > > https://codereview.chromium.org/165723005/diff/1/sdk/lib/core/date_time.dart > File sdk/lib/core/date_time.dart ...

6 years, 10 months ago (2014-02-18 17:12:48 UTC) #3

Lasse Reichstein Nielsen

6 years, 10 months ago (2014-02-19 13:00:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32786 (presubmit successful).

Expand Messages | Collapse Messages

Issue 165723005: Add toIso8601String to DateTime. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. Add test. #

Messages