Issue 16568002: Try out 15 ms safety margin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16568002: Try out 15 ms safety margin. (Closed)

Created:
7 years, 6 months ago by Anton Muhin

Modified:
7 years, 6 months ago

Reviewers:
floitsch, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Try out 15 ms safety margin. If tests start to pass on Windows, it might be a notable clue that Stopwatch implementation on this platform is not precise enough. R=floitsch@google.com BUG=10982 Committed: https://code.google.com/p/dart/source/detail?r=23696

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	tests/lib/async/multiple_timer_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/lib/async/timer_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

LGTM. Would be nice if Dart could work around the imprecision of Windows, but that's ...

7 years, 6 months ago (2013-06-06 16:41:07 UTC) #2

Anton Muhin

7 years, 6 months ago (2013-06-06 16:43:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23696 (presubmit successful).