Issue 16566003: Small fix and cleanups.

Issue 16566003: Small fix and cleanups. (Closed)

Created:
7 years, 6 months ago by srdjan

Modified:
7 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), zra

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Small fix and cleanups. R=vegorov@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23698

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	runtime/vm/bit_vector.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download
	M	runtime/vm/flow_graph_type_propagator.cc	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/16566003/diff/1/runtime/vm/flow_graph_type_propagator.cc File runtime/vm/flow_graph_type_propagator.cc (right): https://codereview.chromium.org/16566003/diff/1/runtime/vm/flow_graph_type_propagator.cc#newcode493 runtime/vm/flow_graph_type_propagator.cc:493: // Type propagation is turned off. ASSERT(!FLAG_propagate_types) or ...

7 years, 6 months ago (2013-06-06 16:44:12 UTC) #3

srdjan

https://codereview.chromium.org/16566003/diff/1/runtime/vm/flow_graph_type_propagator.cc File runtime/vm/flow_graph_type_propagator.cc (right): https://codereview.chromium.org/16566003/diff/1/runtime/vm/flow_graph_type_propagator.cc#newcode493 runtime/vm/flow_graph_type_propagator.cc:493: // Type propagation is turned off. On 2013/06/06 16:44:12, ...

7 years, 6 months ago (2013-06-06 17:01:41 UTC) #5

srdjan

7 years, 6 months ago (2013-06-06 17:11:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r23698 (presubmit successful).

Expand Messages | Collapse Messages