Issue 16550002: Do not listen to errors twice in test_controller.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16550002: Do not listen to errors twice in test_controller.js (Closed)

Created:
7 years, 6 months ago by kustermann

Modified:
7 years, 6 months ago

Reviewers:
ricow1, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, gram

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not listen to errors twice in test_controller.js Currently we have two error handlers in test_controller.js. One is using 'window.onerror = ...' and one is using 'window.addEVentListener("error", ...)'. Doing so will give us the same error twice (i.e. for negative tests / failing tests, we will get an exception which is caused by both mechanisms.) R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23682

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	pkg/unittest/lib/test_controller.js	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #2 manually as r23682 (presubmit successful).

7 years, 6 months ago (2013-06-06 13:32:52 UTC) #3

Siggi Cherem (dart-lang)

7 years, 6 months ago (2013-06-10 21:50:42 UTC) #4

Message was sent while issue was closed.

Long time ago we added both mechanisms because somehow one alone was not enough
to trap all errors we were seeing in all browsers. I never understood why we
need both, and maybe it is not relevant anymore, but just wanted to point that
out. 

+Gram, by any chance do you recall why we needed both?

Expand Messages | Collapse Messages