Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1654063003: pkg/stack_trace: fix vm_test (Closed)

Created:
4 years, 10 months ago by kevmoo
Modified:
4 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/vm_test.dart View 1 2 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
4 years, 10 months ago (2016-02-01 22:34:16 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1654063003/diff/20001/test/vm_test.dart File test/vm_test.dart (right): https://codereview.chromium.org/1654063003/diff/20001/test/vm_test.dart#newcode15 test/vm_test.dart:15: String getStackTraceString() => StackTrace.current.toString(); Add comments explaining why ...
4 years, 10 months ago (2016-02-01 22:46:46 UTC) #3
kevmoo
https://codereview.chromium.org/1654063003/diff/20001/test/vm_test.dart File test/vm_test.dart (right): https://codereview.chromium.org/1654063003/diff/20001/test/vm_test.dart#newcode15 test/vm_test.dart:15: String getStackTraceString() => StackTrace.current.toString(); On 2016/02/01 22:46:46, nweiz wrote: ...
4 years, 10 months ago (2016-02-01 22:48:56 UTC) #4
kevmoo
4 years, 10 months ago (2016-02-01 22:49:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f1e4143d8292c11e7e8744d0145d6180284b0ad0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698