Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 16538002: Move lib from sdk/lib/_internal/compiler/implementation to _internal root. (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move lib from sdk/lib/_internal/compiler/implementation to _internal root. I am doing this to enable me to move out the compiler from the sdk. Committed: https://code.google.com/p/dart/source/detail?r=23902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8583 lines) Patch
D sdk/lib/_internal/compiler/implementation/lib/async_patch.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart View 1 chunk +0 lines, -1330 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/constant_map.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 chunk +0 lines, -309 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart View 1 chunk +0 lines, -173 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +0 lines, -378 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 chunk +0 lines, -305 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 chunk +0 lines, -1420 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 chunk +0 lines, -308 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 chunk +0 lines, -1458 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart View 1 chunk +0 lines, -588 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/js_number.dart View 1 chunk +0 lines, -289 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/js_rti.dart View 1 chunk +0 lines, -297 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/js_string.dart View 1 chunk +0 lines, -283 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/json_patch.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/math_patch.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 1 chunk +0 lines, -313 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart View 1 chunk +0 lines, -142 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/scalarlist_patch.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/string_helper.dart View 1 chunk +0 lines, -201 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/typed_data_patch.dart View 1 chunk +0 lines, -230 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 6 months ago (2013-06-06 09:56:57 UTC) #1
ahe
I would like to see what you do in svn. I'm not sure gcl and ...
7 years, 6 months ago (2013-06-06 10:30:44 UTC) #2
ricow1
Yes this is gcl messing up, the files are actually inside sdk/_internal/lib as you would ...
7 years, 6 months ago (2013-06-06 15:18:34 UTC) #3
ricow1
Committed patchset #1 manually as r23902 (presubmit successful).
7 years, 6 months ago (2013-06-12 10:39:50 UTC) #4
ahe
7 years, 6 months ago (2013-06-12 11:17:57 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698