Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1653603002: pkg/stack_trace: Use StackTrace.current (Closed)

Created:
4 years, 10 months ago by kevmoo
Modified:
4 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -42 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/trace.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/trace_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M test/vm_test.dart View 1 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
I figured you might want to be clever and try to catch the call to ...
4 years, 10 months ago (2016-01-29 23:13:24 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1653603002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1653603002/diff/1/CHANGELOG.md#newcode5 CHANGELOG.md:5: * Require at least Dart SDK 1.14. I ...
4 years, 10 months ago (2016-02-01 19:56:29 UTC) #3
kevmoo
https://codereview.chromium.org/1653603002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1653603002/diff/1/CHANGELOG.md#newcode5 CHANGELOG.md:5: * Require at least Dart SDK 1.14. On 2016/02/01 ...
4 years, 10 months ago (2016-02-01 22:20:07 UTC) #4
kevmoo
4 years, 10 months ago (2016-02-01 22:20:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
578a38089131e3a51731e9cead77566e9302c358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698