Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 165353002: fix accidental breaking changes in html5lib, deprecate instead (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

fix accidental breaking changes in html5lib, deprecate instead R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=32680

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M pkg/third_party/html5lib/CHANGELOG.md View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/dom.dart View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
Kevin, mind taking a look? Thanks for noticing this! It completely slipped my mind that ...
6 years, 10 months ago (2014-02-13 23:48:09 UTC) #1
kevmoo
lgtm
6 years, 10 months ago (2014-02-13 23:50:02 UTC) #2
Jennifer Messerly
Committed patchset #3 manually as r32680 (presubmit successful).
6 years, 10 months ago (2014-02-13 23:50:49 UTC) #3
Siggi Cherem (dart-lang)
6 years, 10 months ago (2014-02-14 02:27:52 UTC) #4
Message was sent while issue was closed.
:) lgtm

Powered by Google App Engine
This is Rietveld 408576698