Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652413002: Use StreamChannel. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/json_rpc_2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use StreamChannel. This converts the constructors to take StreamChannels, and changes some edge-case semantics to be more familiar to StreamChannel (and WebSocket) users. R=rnystrom@google.com Committed: https://github.com/dart-lang/json_rpc_2/commit/d6afedc5f1cb77531c80d7505a9d8e454a3c1bf8

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -424 lines) Patch
M CHANGELOG.md View 1 chunk +18 lines, -0 lines 0 comments Download
M README.md View 1 2 chunks +87 lines, -91 lines 0 comments Download
A lib/src/channel_manager.dart View 1 1 chunk +79 lines, -0 lines 0 comments Download
M lib/src/client.dart View 1 5 chunks +31 lines, -32 lines 0 comments Download
M lib/src/peer.dart View 5 chunks +23 lines, -46 lines 0 comments Download
M lib/src/server.dart View 1 4 chunks +46 lines, -48 lines 0 comments Download
D lib/src/two_way_stream.dart View 1 chunk +0 lines, -135 lines 0 comments Download
M lib/src/utils.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +3 lines, -3 lines 0 comments Download
M test/client/stream_test.dart View 4 chunks +14 lines, -32 lines 0 comments Download
M test/client/utils.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M test/peer_test.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M test/server/stream_test.dart View 4 chunks +14 lines, -31 lines 0 comments Download
M test/server/utils.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 10 months ago (2016-02-02 02:07:29 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1652413002/diff/1/README.md File README.md (right): https://codereview.chromium.org/1652413002/diff/1/README.md#newcode15 README.md:15: var socket = WebSocket.connect('ws://localhost:4321'); await https://codereview.chromium.org/1652413002/diff/1/README.md#newcode86 README.md:86: var ...
4 years, 10 months ago (2016-02-02 17:54:15 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-02-02 20:20:37 UTC) #3
nweiz
4 years, 10 months ago (2016-02-02 20:21:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d6afedc5f1cb77531c80d7505a9d8e454a3c1bf8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698