Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 16520006: Don't double-count stack slots when compiling optimized try-catch. (Closed)

Created:
7 years, 6 months ago by Florian Schneider
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't double-count stack slots when compiling optimized try-catch. The fixed slots used by try-catch are already accounted for in the register allocator. This change avoids wasting unnecessary stack space for optimized functions containing try-catch. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=23899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
Thanks Kevin for pointing this out.
7 years, 6 months ago (2013-06-12 08:44:24 UTC) #1
Kevin Millikin (Google)
lgtm
7 years, 6 months ago (2013-06-12 09:25:22 UTC) #2
Florian Schneider
7 years, 6 months ago (2013-06-12 09:31:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698