Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165143004: Move TypeMask.simplify to a test helper. (Closed)

Created:
6 years, 10 months ago by polux
Modified:
6 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move TypeMask.simplify to a test helper. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32853

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -57 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/concrete_types_inferrer.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/forwarding_type_mask.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/type_mask.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -8 lines 0 comments Download
M tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/closure_tracer_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/issue13354_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/list_tracer2_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/list_tracer3_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mirror_final_field_inferrer2_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mirror_final_field_inferrer_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_and_or_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_closure_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure3_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure4_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure5_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field3_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_global_field_closure2_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 4 chunks +9 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
A tests/compiler/dart2js/type_mask_test_helper.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
polux
6 years, 10 months ago (2014-02-14 16:21:09 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/165143004/diff/1/tests/compiler/dart2js/type_mask_test_helper.dart File tests/compiler/dart2js/type_mask_test_helper.dart (right): https://codereview.chromium.org/165143004/diff/1/tests/compiler/dart2js/type_mask_test_helper.dart#newcode12 tests/compiler/dart2js/type_mask_test_helper.dart:12: if (mask.isForwarding) { Perhaps use is-checks here, that ...
6 years, 10 months ago (2014-02-18 13:25:06 UTC) #2
polux
https://codereview.chromium.org/165143004/diff/1/tests/compiler/dart2js/type_mask_test_helper.dart File tests/compiler/dart2js/type_mask_test_helper.dart (right): https://codereview.chromium.org/165143004/diff/1/tests/compiler/dart2js/type_mask_test_helper.dart#newcode12 tests/compiler/dart2js/type_mask_test_helper.dart:12: if (mask.isForwarding) { On 2014/02/18 13:25:06, karlklose wrote: > ...
6 years, 10 months ago (2014-02-20 16:51:57 UTC) #3
polux
6 years, 10 months ago (2014-02-20 16:53:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r32853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698