Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165113003: Process Windows docgen command-line parameter correctly (Closed)

Created:
6 years, 10 months ago by aam-me
Modified:
6 years, 10 months ago
Reviewers:
Alan Knight, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Process docgen command-line parameter correctly. BUGS=dartbug.com/16964 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=32848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/bin/docgen.bat View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aam-me
Hi Alan, saw the bug mentioned on dart-misc. Seems to be simple typo. Hope this ...
6 years, 10 months ago (2014-02-20 11:11:50 UTC) #1
kasperl
LGTM!
6 years, 10 months ago (2014-02-20 11:13:05 UTC) #2
aam-me
Committed patchset #1 manually as r32848 (presubmit successful).
6 years, 10 months ago (2014-02-20 11:18:29 UTC) #3
Alan Knight
6 years, 10 months ago (2014-02-20 17:37:23 UTC) #4
Message was sent while issue was closed. 
Thanks!

Powered by Google App Engine
This is Rietveld 408576698