Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 16510003: Make [HTypeConversion] with NO_CHECK code motion invariant to ensure no code is generated for it. (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
karlklose, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make [HTypeConversion] with NO_CHECK code motion invariant to ensure no code is generated for it. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/generate_at_use_site_test.dart View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-12 07:06:56 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-12 10:45:18 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-12 14:59:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698