Expand overloaded methods and optional parameters in the html library.

Expand overloaded methods and optional parameters in the html library.

BUG=
R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24655

[Emily Fortuna, 2013-06-11 21:14:59]

There are some more to go, but this is a chunk of them.

[Emily Fortuna, 2013-06-17 21:48:07]

ptal

[blois, 2013-06-18 18:11:21]

Some comments inline, but also wondering what sort of error handling there is
here for when new overloads are introduced.

https://codereview.chromium.org/16494002/diff/11002/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/16494002/diff/11002/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1161: CanvasPattern
createPattern(CanvasElement canvas, String repetitionType) native;
I think that all variants should be named, in case we decide to add back the
general one to support the (CanvasElement|ImageElement) scenario.

For example, we should have:

createPatternFromCanvas(CanvasElement canvas, ...)
createPatternFromImage(ImageElement image, ...)

Then if we want to, later we can do:

createPattern(canvasOrImage, ...)

https://codereview.chromium.org/16494002/diff/11002/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/16494002/diff/11002/tools/dom/idl/dart/dart.i...
tools/dom/idl/dart/dart.idl:71: [DartName=texImage2DData] void
texImage2D(unsigned long target, long level, unsigned long internalformat,
unsigned long format, unsigned long type, ImageData pixels);
I'd strongly prefer having a rename table elsewhere so we don't duplicate the
definition of these methods, also it would set us up better for the removal of
this file.

[Emily Fortuna, 2013-06-22 01:00:29]

ptal

[blois, 2013-06-24 16:58:02]

https://codereview.chromium.org/16494002/diff/40001/sdk/lib/indexed_db/dart2j...
File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right):

https://codereview.chromium.org/16494002/diff/40001/sdk/lib/indexed_db/dart2j...
sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:270: Transaction
transactionString(String storeName, String mode) {
can this be transactionStore and transactionStores?

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:34: _renamed_overloads =
monitored.Dict('htmldartgenreator.renamed_overloads', {
Could this go to htmlrenamer, just to keep our renames consolidated?

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:199: # This function gets called twice
per interface if we generate both dart2js
Is there a more central place we can do this, so it doesn't get called twice?

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:202: already_renamed =
[operation.ext_attrs['DartName'] if 'DartName' in
Doesn't have to be in this CL, but we should remove all 'DartName' attributes to
the table.

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:205: for operation in
interface.operations:
Are there any warnings when there are overloads that have not been separated?

[Emily Fortuna, 2013-06-25 03:53:31]

https://codereview.chromium.org/16494002/diff/40001/sdk/lib/indexed_db/dart2j...
File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right):

https://codereview.chromium.org/16494002/diff/40001/sdk/lib/indexed_db/dart2j...
sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:270: Transaction
transactionString(String storeName, String mode) {
On 2013/06/24 16:58:02, blois wrote:
> can this be transactionStore and transactionStores?

Done.

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:34: _renamed_overloads =
monitored.Dict('htmldartgenreator.renamed_overloads', {
On 2013/06/24 16:58:02, blois wrote:
> Could this go to htmlrenamer, just to keep our renames consolidated?

Done.

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:199: # This function gets called twice
per interface if we generate both dart2js
On 2013/06/24 16:58:02, blois wrote:
> Is there a more central place we can do this, so it doesn't get called twice?

Not really if we do it in the python scripts, unless I put the call in the very
top level dartdomgenerator.py script or when we're reading in the database from
the IDL, which is odd because no modifications happen there. Despite the fact
that we have to make sure this runs only once, functionally, it seems more in
keeping to keep it here.

https://codereview.chromium.org/16494002/diff/40001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:205: for operation in
interface.operations:
On 2013/06/24 16:58:02, blois wrote:
> Are there any warnings when there are overloads that have not been separated?

added a warning output, but it's not super useful for the amount of additional
code added. See what you think.

[Emily Fortuna, 2013-06-28 18:39:19]

and so the Epic CL goes out for another iteration.

[blois, 2013-06-28 20:57:48]

https://codereview.chromium.org/16494002/diff/65001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/16494002/diff/65001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:155: print 'WARNING: Multiple type
signatures for %s.%s' % (
This should use the logging mechanism.

https://codereview.chromium.org/16494002/diff/72001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/16494002/diff/72001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:183: print ('Rename one of the methods in
renamed_overloads or add it to '
Using logging infrastructure

https://codereview.chromium.org/16494002/diff/72001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:186: sys.exit(1)
raise an error instead?

[Emily Fortuna, 2013-06-28 21:40:18]

ptal

[blois, 2013-06-28 22:39:36]

lgtm

[Emily Fortuna, 2013-07-01 20:49:23]

Committed patchset #8 manually as r24655 (presubmit successful).