Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 164913007: remove pkg/browser/lib/interop.js (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 10 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

remove pkg/browser/lib/interop.js it's not really needed -- the same functionality can be achieved in dart:js's implementation R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=32943

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M pkg/browser/README.md View 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/browser/lib/interop.js View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/browser/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/js/dart2js/js_dart2js.dart View 10 chunks +14 lines, -10 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
https://codereview.chromium.org/164913007/diff/1/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/164913007/diff/1/sdk/lib/js/dart2js/js_dart2js.dart#newcode487 sdk/lib/js/dart2js/js_dart2js.dart:487: final _dartProxyCtor = JS('', 'function DartObject(o) { this.o = ...
6 years, 10 months ago (2014-02-19 00:37:23 UTC) #1
Jennifer Messerly
note: this is actually deprecating with a friendly msg, not removing just yet :)
6 years, 10 months ago (2014-02-19 00:37:50 UTC) #2
Jennifer Messerly
ping :) this would really help remove one extra script tag a user needs to ...
6 years, 10 months ago (2014-02-20 22:03:53 UTC) #3
justinfagnani
lgtm
6 years, 10 months ago (2014-02-21 23:20:12 UTC) #4
Jennifer Messerly
6 years, 10 months ago (2014-02-21 23:35:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r32943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698