pkg/scheduled_test: formatter

pkg/scheduled_test: formatter

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32826

[nweiz, 2014-02-13 22:01:53]

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
File pkg/scheduled_test/lib/descriptor.dart (right):

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
pkg/scheduled_test/lib/descriptor.dart:103: new FileDescriptor.binary(name,
contents);
I don't like this change. I think "=>" methods should be allowed to be indented
two spaces, since they're effectively method bodies. I don't think switching
from "{}" to "=>" should require changing the body's indentation.

[kevmoo, 2014-02-17 20:00:19]

Other comments other than the indent?

We might could talk to Bob about the style guide here.

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
File pkg/scheduled_test/lib/descriptor.dart (right):

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
pkg/scheduled_test/lib/descriptor.dart:103: new FileDescriptor.binary(name,
contents);
If a line is considered a continuation, its indent is 4.

This is consistent with our other styles.

[kevmoo, 2014-02-19 16:48:09]

PTAL

[nweiz, 2014-02-19 21:13:46]

Bob and I have discussed this indentation issue in the past and ended up
deadlocked.

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
File pkg/scheduled_test/lib/descriptor.dart (right):

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
pkg/scheduled_test/lib/descriptor.dart:103: new FileDescriptor.binary(name,
contents);
On 2014/02/17 20:00:19, kevmoo wrote:
> If a line is considered a continuation, its indent is 4.
> 
> This is consistent with our other styles.

I don't think these lines should be considered continuations, since they're
effectively the body of the function.

[Bob Nystrom, 2014-02-19 21:18:54]

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
File pkg/scheduled_test/lib/descriptor.dart (right):

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
pkg/scheduled_test/lib/descriptor.dart:103: new FileDescriptor.binary(name,
contents);
On 2014/02/19 21:13:46, nweiz wrote:
> they're effectively method bodies.

Except that unlike method bodies, they implicitly return their result. When
converting from one to the other, it's easy to forget to add/remove the
"return".

I think it's worth having different indentation to highlight that fact.

[nweiz, 2014-02-19 21:33:56]

lgtm

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
File pkg/scheduled_test/lib/descriptor.dart (right):

https://codereview.chromium.org/164883002/diff/1/pkg/scheduled_test/lib/descr...
pkg/scheduled_test/lib/descriptor.dart:103: new FileDescriptor.binary(name,
contents);
On 2014/02/19 21:18:54, Bob Nystrom wrote:
> On 2014/02/19 21:13:46, nweiz wrote:
> > they're effectively method bodies.
> 
> Except that unlike method bodies, they implicitly return their result. When
> converting from one to the other, it's easy to forget to add/remove the
> "return".
> 
> I think it's worth having different indentation to highlight that fact.

I don't agree, but it seems I'm in the minority on this so I'll switch.

[kevmoo, 2014-02-19 21:49:35]

Committed patchset #3 manually as r32826 (presubmit successful).