Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1648723002: Fix the old-hijack test. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the old-hijack test. We were testing for `is ZoneUnaryCallback` on a function returned by expectAsync(). It turns out the expectAsync() wrappers make all arguments optional, so `is ZoneUnaryCallback` returns true even if the original function took two arguments. So instead, we test for `is! ZoneBinaryCallback`. R=kevmoo@google.com Committed: https://github.com/dart-lang/shelf/commit/60e3f7fbfcc30ddb53b45cd0dc13361d38d1cdbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/request.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 10 months ago (2016-01-28 19:01:15 UTC) #1
kevmoo
lgtm
4 years, 10 months ago (2016-01-28 19:59:53 UTC) #2
nweiz
4 years, 10 months ago (2016-01-28 20:00:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
60e3f7fbfcc30ddb53b45cd0dc13361d38d1cdbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698