Issue 164823006: Remove LibraryMirror.topLevelMembers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164823006: Remove LibraryMirror.topLevelMembers. (Closed)

Created:
6 years, 10 months ago by rmacnak

Modified:
6 years, 9 months ago

Reviewers:
ahe, gbracha

CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -141 lines)			Patch
M	runtime/lib/mirrors_impl.dart	View		1 chunk	+0 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	tests/lib/lib.status	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tests/lib/mirrors/immutable_collections_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/lib/mirrors/mirrors_reader.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/mirrors/synthetic_accessor_properties_test.dart	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	tests/lib/mirrors/toplevel_members_test.dart	View		1 chunk	+0 lines, -56 lines	0 comments	Download

Total messages: 4 (0 generated)

gbracha

lgtm, but we do need to be very careful pushing these out so we do ...

6 years, 10 months ago (2014-02-14 18:53:45 UTC) #2

ahe

On 2014/02/14 18:53:45, gbracha wrote: > lgtm, but we do need to be very careful ...

6 years, 10 months ago (2014-02-21 10:55:51 UTC) #3

rmacnak

6 years, 9 months ago (2014-03-04 01:35:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r33256 (presubmit successful).