Issue 164743003: Remove the html warnings!

Issue 164743003: Remove the html warnings! (Closed)

Created:
6 years, 10 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove the html warnings! BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32678

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+310 lines, -107 lines)			Patch
M	pkg/custom_element/lib/custom_element.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	16 chunks	+106 lines, -49 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	16 chunks	+97 lines, -40 lines	0 comments	Download
M	sdk/lib/html/html_common/lists.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/analyze_api_test.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tools/dom/dom.json	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/dom/src/EventStreamProvider.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/src/WrappedEvent.dart	View	2 chunks	+41 lines, -0 lines	0 comments	Download
M	tools/dom/src/dart2js_DOMImplementation.dart	View	1 chunk	+11 lines, -0 lines	1 comment	Download
M	tools/dom/src/dart2js_KeyEvent.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/dom/src/dartium_KeyEvent.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_AbstractWorker.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Almost identical. The one new file has a comment in it. https://codereview.chromium.org/164743003/diff/1/tools/dom/src/dart2js_DOMImplementation.dart File tools/dom/src/dart2js_DOMImplementation.dart (right): ...

6 years, 10 months ago (2014-02-13 22:12:05 UTC) #1

Emily Fortuna

6 years, 10 months ago (2014-02-13 22:23:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32678 (presubmit successful).

Expand Messages | Collapse Messages