Issue 16471002: Add dartdoc to the generated utils snapshot.

Issue 16471002: Add dartdoc to the generated utils snapshot. (Closed)

Created:
7 years, 6 months ago by Andrei Mouravski

Modified:
7 years, 6 months ago

Reviewers:
dgrove

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add dartdoc to the generated utils snapshot. Lots of bad patches should be fixed in this change. R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=23655

Patch Set 3 : CR changes. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -29 lines)			Patch
M	sdk/bin/dartdoc	View		1 chunk	+12 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1 2	1 chunk	+27 lines, -17 lines	0 comments	Download
M	utils/compiler/compiler.gyp	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	utils/compiler/create_snapshot.dart	View		6 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgrove

https://codereview.chromium.org/16471002/diff/2001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/16471002/diff/2001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode792 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:792: String get rootDirectory => rootDirectory => sdkDir https://codereview.chromium.org/16471002/diff/2001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode803 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:803: ...

7 years, 6 months ago (2013-06-05 20:16:12 UTC) #2

Andrei Mouravski

PTAL. https://codereview.chromium.org/16471002/diff/2001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/16471002/diff/2001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode792 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:792: String get rootDirectory => On 2013/06/05 20:16:12, dgrove ...

7 years, 6 months ago (2013-06-05 20:21:12 UTC) #3

Andrei Mouravski

7 years, 6 months ago (2013-06-05 20:32:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r23655 (presubmit successful).

Expand Messages | Collapse Messages