Add leading slash to URI path when required.

Add leading slash to URI path when required.

R=lrn@google.com
BUG=http://dartbug.com/11105

Committed: https://code.google.com/p/dart/source/detail?r=23686

[Lasse Reichstein Nielsen, 2013-06-06 11:50:32]

lgtm

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart#newcode177
sdk/lib/core/uri.dart:177: _path = _makePath(path, pathSegments);
But _makePath was changed to return void?

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart#newcode270
sdk/lib/core/uri.dart:270: !result.isEmpty && result.codeUnitAt(0) != _SLASH) {
result.startsWith("/") ?

(and remember isNotEmpty :)

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart#newcode271
sdk/lib/core/uri.dart:271: return "/${result}";
No need for { and } around "result".

[Søren Gjesse, 2013-06-06 14:06:53]

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart#newcode177
sdk/lib/core/uri.dart:177: _path = _makePath(path, pathSegments);
On 2013/06/06 11:50:32, Lasse Reichstein Nielsen wrote:
> But _makePath was changed to return void?

And that was wrong.

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart#newcode270
sdk/lib/core/uri.dart:270: !result.isEmpty && result.codeUnitAt(0) != _SLASH) {
On 2013/06/06 11:50:32, Lasse Reichstein Nielsen wrote:
> result.startsWith("/") ?
> 
> (and remember isNotEmpty :)

Done.

https://codereview.chromium.org/16470004/diff/1/sdk/lib/core/uri.dart#newcode271
sdk/lib/core/uri.dart:271: return "/${result}";
On 2013/06/06 11:50:32, Lasse Reichstein Nielsen wrote:
> No need for { and } around "result".

Done.

[Søren Gjesse, 2013-06-06 14:06:59]

Committed patchset #2 manually as r23686 (presubmit successful).