Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1646583003: Add a WebSocketChannel class. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http_parser@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a WebSocketChannel class. This deprecates CompatibleWebSocket in favor of the new class. R=rnystrom@google.com Committed: https://github.com/dart-lang/http_parser/commit/825b429907d4638bcb3605fd8c424a6fc14adb76

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -221 lines) Patch
M CHANGELOG.md View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M README.md View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/web_socket.dart View 1 chunk +3 lines, -108 lines 0 comments Download
A + lib/src/web_socket/channel.dart View 1 2 4 chunks +46 lines, -35 lines 0 comments Download
A + lib/src/web_socket/deprecated.dart View 2 chunks +4 lines, -21 lines 0 comments Download
A lib/src/web_socket/exception.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M test/web_socket_test.dart View 1 3 chunks +139 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 10 months ago (2016-01-28 06:20:05 UTC) #2
Bob Nystrom
lgtm
4 years, 10 months ago (2016-01-28 19:19:35 UTC) #3
nweiz
4 years, 10 months ago (2016-01-28 20:07:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
825b429907d4638bcb3605fd8c424a6fc14adb76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698