Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1645993002: Allow users of MultiProtocolHttpServer to pass http.ServerSettings (Closed)

Created:
4 years, 10 months ago by kustermann
Modified:
4 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow users of MultiProtocolHttpServer to pass http.ServerSettings R=sgjesse@google.com Committed: https://github.com/dart-lang/http2/commit/768803a60e2b24a0b929d7df7cb911ea871b2c45

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M lib/multiprotocol_server.dart View 1 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
4 years, 10 months ago (2016-01-28 17:05:20 UTC) #2
Søren Gjesse
lgtm
4 years, 10 months ago (2016-01-28 18:05:14 UTC) #3
kustermann
4 years, 10 months ago (2016-02-02 17:44:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
768803a60e2b24a0b929d7df7cb911ea871b2c45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698