Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 16452013: Fix the isolate unit tests to create an isolate from a snapshot. (Closed)

Created:
7 years, 6 months ago by siva
Modified:
7 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the isolate unit tests to create an isolate from a snapshot. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M runtime/vm/benchmark_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 6 months ago (2013-06-05 17:00:49 UTC) #1
zra
lgtm I checked, and this fixes these tests failing on ARM.
7 years, 6 months ago (2013-06-05 17:24:06 UTC) #2
siva
7 years, 6 months ago (2013-06-05 17:44:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698