Issue 164503002: Trace VM service requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164503002: Trace VM service requests (Closed)

Created:
6 years, 10 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Trace VM service requests BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=32751

Patch Set 4 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -81 lines)			Patch
A	runtime/bin/vmservice/client/HACKING.txt	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	runtime/vm/json_stream.h	View	1 2 3	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/json_stream.cc	View	1 2 3	2 chunks	+95 lines, -1 line	0 comments	Download
M	runtime/vm/service.cc	View	1 2	6 chunks	+27 lines, -80 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

turnidge

https://codereview.chromium.org/164503002/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/164503002/diff/1/runtime/vm/service.cc#newcode612 runtime/vm/service.cc:612: PostReply(&js); I suggest moving the initial timer code and ...

6 years, 10 months ago (2014-02-13 20:49:51 UTC) #2

Cutch

6 years, 10 months ago (2014-02-18 17:50:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r32751 (presubmit successful).

Expand Messages | Collapse Messages

Issue 164503002: Trace VM service requests (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages