Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 16415013: Increase timeout for simarm (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1, zra, regis
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Increase timeout for simarm TBR=zra Committed: https://code.google.com/p/dart/source/detail?r=23919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
I hope this was the last change.
7 years, 6 months ago (2013-06-12 16:55:49 UTC) #1
kustermann
Committed patchset #1 manually as r23919 (presubmit successful).
7 years, 6 months ago (2013-06-12 16:56:18 UTC) #2
ricow1
Generated code will run much slower on the simulator (way more than 4x compared to ...
7 years, 6 months ago (2013-06-12 17:25:28 UTC) #3
regis
7 years, 6 months ago (2013-06-12 17:43:40 UTC) #4
Message was sent while issue was closed.
On 2013/06/12 17:25:28, ricow1 wrote:
> Generated code will run much slower on the simulator (way more than 4x
compared
> to bare metal). Given that we spend most time in c code for small unit test
you
> are right that this will just make it worse for triaging those tests. Tests
that
> actually do considerable work in generated code will be _much_ slower and this
> seems like a balanced approach to actually have these run to the end. There is
a
> number of tests that will have a 1000+ loop to get code optimize (I suggested
> another approach for this to Ivan, don't know if this is something that we
will
> see)
> If you need to triage tests locally and you find this painful you can pass in
> --timeout=XX (XX being seconds)
> We don't really care much if we put this back to the standard timeout, but a
> number of possibly useful tests will time out or needs to manually be marked
> slow.

I appreciate you guys triaging failing tests on ARM, but this is premature, in
my opinion.
Marking a test as Pass, Crash, and Timeout, all at the same time does not help
in any way.

Until now, we left most tests marked as Skip and we made great progress fixing
bugs and implementing code, rather than maintaining test status files.

Having a higher timeout is also counterproductive, because tests take forever to
finish. I am convinced that many tests are in endless loops, rather than timing
out.

I suggest we revert the timeout as it was earlier today and skip tests timing
out, until we fix more bugs.

I would not be surprised if the simulator runs faster than the bare metal for
some tests.

Thanks,
Regis

Powered by Google App Engine
This is Rietveld 408576698