Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1641353002: Expand the JSON reporter to enable a progress bar. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
alexander.doroshko, alexander.doroshko, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand the JSON reporter to enable a progress bar. This adds an event that prints the total number of suites that will be loaded, and includes the number of tests to be run in each group. This enables a monotonic (if not entirely accurate) progress bar. Closes #366 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/42bb1ebb6330a3e435276e26371c8fd217fe9bae

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -21 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 1 comment Download
M json_reporter.md View 2 chunks +19 lines, -0 lines 1 comment Download
M json_reporter.schema.json View 3 chunks +13 lines, -3 lines 0 comments Download
M lib/src/backend/group.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M lib/src/runner/engine.dart View 4 chunks +25 lines, -1 line 0 comments Download
M lib/src/runner/reporter/json.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/json_reporter_test.dart View 15 chunks +43 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nweiz
4 years, 10 months ago (2016-01-28 21:43:10 UTC) #2
kevmoo
lgtm
4 years, 10 months ago (2016-01-28 22:28:51 UTC) #3
nweiz
Committed patchset #1 (id:1) manually as 42bb1ebb6330a3e435276e26371c8fd217fe9bae (presubmit successful).
4 years, 10 months ago (2016-01-28 22:44:54 UTC) #5
nweiz
On 2016/01/28 22:44:54, nweiz wrote: > Committed patchset #1 (id:1) manually as > 42bb1ebb6330a3e435276e26371c8fd217fe9bae (presubmit ...
4 years, 10 months ago (2016-01-28 22:45:44 UTC) #6
alexander.doroshko
lgtm https://codereview.chromium.org/1641353002/diff/1/json_reporter.md File json_reporter.md (right): https://codereview.chromium.org/1641353002/diff/1/json_reporter.md#newcode104 json_reporter.md:104: ### SuiteCountEvent mismatch with the class name AllSuitesEvent
4 years, 10 months ago (2016-01-29 11:51:05 UTC) #8
alexander.doroshko
4 years, 10 months ago (2016-02-02 11:02:28 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1641353002/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1641353002/diff/1/CHANGELOG.md#newcode9
CHANGELOG.md:9: * Add `GroupEvent.testCount` to the JSON reporter, which reports
the total
Group.testCount is added, not GroupEvent.testCount

Powered by Google App Engine
This is Rietveld 408576698