Issue 164133003: Only inline Int32/Uint32 list view stores if we can unbox integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164133003: Only inline Int32/Uint32 list view stores if we can unbox integers. (Closed)

Created:
6 years, 10 months ago by Cutch

Modified:
6 years, 10 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only inline Int32/Uint32 list view stores if we can unbox integers. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32672

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r32672 (presubmit successful).

6 years, 10 months ago (2014-02-13 20:53:40 UTC) #2

zra

6 years, 10 months ago (2014-02-13 20:56:35 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/164133003/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/164133003/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:1381: if (!CanUnboxInt32()) return false;
Please add curly braces.

if (!CanUnboxInt32()) {
  return false;
}

https://codereview.chromium.org/164133003/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:1386: if (!CanUnboxInt32()) return false;
Curly braces.

Expand Messages | Collapse Messages